bugGNU Octave - Bugs: bug #38558, control: @lti/feedback doesn't...

 
 

bug #38558: control: @lti/feedback doesn't check system blocks dimensions

Submitted by:  None
Submitted on:  Wed 20 Mar 2013 08:13:25 PM UTC  
 
Category: Octave Forge PackageSeverity: 3 - Normal
Priority: 5 - NormalItem Group: Incorrect Result
Status: Patch SubmittedAssigned to: None
Originator Name: Jack OlivieriOriginator Email: -unavailable-
Open/Closed: OpenRelease: 3.6.2
Operating System: GNU/Linux

Add a New Comment (Rich MarkupRich Markup):
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Sat 26 Oct 2013 09:40:05 AM UTC, comment #2:

Thanks for the report. Note that you are using a very outdated version of control (2.3.52), the current version is control 2.6.0. IIRC, this bug has been fixed in control 2.3.53 (hg revision 774). Could you please double-check the current version in the link below if that is the case?

http://sourceforge.net/p/octave/control/ci/default/tree/inst/@lti/feedback.m

Lukas Reichlin <paramaniac>
Sat 26 Oct 2013 09:19:04 AM UTC, comment #1:

Added maintainer of the control package to the Mail Notification Carbon-Copy List.

Carnë Draug <carandraug>
Project Member
Wed 20 Mar 2013 08:13:25 PM UTC, original submission:

The function doesn't correctly perform the check on the system blocks dimensions (see function documentation before proceeding).
The check should make sure that the 'feedout' indeces don't exceed the dimension of the output of 'sys1', namely the forward block for the feedback function. Instead, the function performs that check on the local variable 'feedin'.

What the function DOES:
/usr/share/octave/packages/control-2.3.52/@lti/feedback.m:line 131

What the function SHOULD DO:
/usr/share/octave/packages/control-2.3.52/@lti/feedback.m:line 131

Anonymous

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by paramaniac (Posted a comment)
  • -unavailable- added by carandraug (maintainer of control package)
  • -unavailable- added by jordigh (Updated the item)
  • -unavailable- added by None (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only project members can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 4 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Sat 26 Oct 2013 09:19:04 AM UTCcarandraugSummary@lti/feedback doesn\'t check system blocks dimensions=>control: @lti/feedback doesn't check system blocks dimensions
      Carbon-Copy-=>Added -unavailable-
    Thu 21 Mar 2013 04:12:47 PM UTCjordighStatusNone=>Patch Submitted
      SummaryBug in function @lti/feedback=>@lti/feedback doesn't check system blocks dimensions

    Back to the top


    Powered by Savane 3.1-cleanup