bugGNU Octave - Bugs: bug #38370, Gnuplot 4.2 warns about termoption...

 
 

bug #38370: Gnuplot 4.2 warns about termoption dashed

Submitted by:  Mike Miller <mtmiller>
Submitted on:  Fri 22 Feb 2013 12:37:55 AM UTC  
 
Category: Plotting with gnuplotSeverity: 2 - Minor
Priority: 5 - NormalItem Group: Incorrect Result
Status: FixedAssigned to: None
Originator Name: Open/Closed: Closed
Release: devOperating System: Any

Add a New Comment (Rich MarkupRich Markup):
   

You are not logged in

Please log in, so followups can be emailed to you.

 

(Jump to the original submission Jump to the original submission)

Sun 24 Feb 2013 03:27:03 PM UTC, comment #6:

I pushed a changeset here (http://hg.savannah.gnu.org/hgweb/octave/rev/1339c964b527). Marking this issue as fixed and closing the report.

Rik <rik5>
Project Administrator
Sat 23 Feb 2013 09:30:07 PM UTC, comment #5:

Rik,

I was under the impression that the "term" variable could be "postscript eps". But after looking further, it obviously is not.

Feel free to push the change. Or if you like, I add the changelog and push it myself.

Ben Abbott <bpabbott>
Project Member
Sat 23 Feb 2013 08:04:50 PM UTC, comment #4:

Tested Rik's latest patch, it fixes the problem I was seeing with gnuplot 4.2.

Mike Miller <mtmiller>
Project Member
Sat 23 Feb 2013 07:03:50 PM UTC, comment #3:

Ben,

I modified your patch slightly. I added a few more terminals (pdfcairo, pngcairo, svg) and I also took out this line

which looks like a cut-and-paste from some other function. In this case it was always setting the term to postscript and term is actually an input to the _gnuplot_drawnow_ function.

I've attached the patch for your review.

(file #27512)

Rik <rik5>
Project Administrator
Sat 23 Feb 2013 02:57:31 AM UTC, comment #2:

Rik,

I've lost track of which terminals we're currently supporting, and concerned that we may end up including the "dashed" option to a terminal that doesn't support it. So I thought it wise to do something a bit more complicated.

Does the attached look ok to you?

(file #27505)

Ben Abbott <bpabbott>
Project Member
Fri 22 Feb 2013 05:21:18 PM UTC, comment #1:

This is a problem only with the 4.2.X branch of gnuplot. It seems that the dashed termoption can not be changed after the terminal is created. However, the terminal can be created with the dashed option fixed in place. I've attached a quick-and-dirty patch for _gnuplot_drawnow_.m which seems to work. I'm also adding Ben to the CC list since he knows much more about this plotting stuff than I do. It would seem like an easy fix.

(file #27502)

Rik <rik5>
Project Administrator
Fri 22 Feb 2013 12:37:55 AM UTC, original submission:

I read the discussion about this recent change:

http://octave.1599824.n4.nabble.com/gnuplot-and-dashed-lines-td4648154.html

I admittedly did not pay attention at the time, but now I'm seeing warnings on every plot command on systems with gnuplot 4.2:

Set to minor because nothing really breaks, it's just annoying warning text. It would be nice to avoid this, though, if gnuplot doesn't support this command.

Mike Miller <mtmiller>
Project Member

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files
file #27512:  patch.dashed added by rik5 (3kB - application/octet-stream)
file #27505:  changeset.patch added by bpabbott (3kB - application/octet-stream)
file #27502:  patch.termoption added by rik5 (962B - application/octet-stream)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by bpabbott (Updated the item)
  • -unavailable- added by rik5 (Updated the item)
  • -unavailable- added by rik5
  • -unavailable- added by mtmiller (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only project members can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 7 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Sun 24 Feb 2013 03:27:02 PM UTCrik5StatusConfirmed=>Fixed
      Open/ClosedOpen=>Closed
    Sat 23 Feb 2013 07:03:50 PM UTCrik5Attached File-=>Added patch.dashed, #27512
    Sat 23 Feb 2013 02:57:31 AM UTCbpabbottAttached File-=>Added changeset.patch, #27505
    Fri 22 Feb 2013 05:21:18 PM UTCrik5Attached File-=>Added patch.termoption, #27502
      StatusNone=>Confirmed
      Carbon-Copy-=>Added -unavailable-

    Back to the top


    Powered by Savane 3.1-cleanup