bugGNU Octave - Bugs: bug #37773, Add --without-fltk switch to...

 
 

bug #37773: Add --without-fltk switch to configure

Submitter:  Patrick Welche <prlw1>
Submitted:  Mon 19 Nov 2012 12:45:37 PM UTC
   
 
Category:  Configuration and Build System Severity:  1 - Wish
Priority:  5 - Normal Item Group:  Installation Failure
Status:  Fixed Assigned to:  mtmiller
Originator Name:  Open/Closed:  * Closed
Release:  * dev Operating System:  * Any
Fixed Release:  None Planned Release:  None
* Mandatory Fields

Add a New Comment Rich Markup
   

Jump to the original submission

Fri 16 Jan 2015 02:31:49 AM UTC, comment #13: 

I just pushed your patch, with some extremely minor changes, to the default branch:

http://hg.savannah.gnu.org/hgweb/octave/rev/27c5f42a7a64

Not sure if this is important enough to warrant going in the gui-release branch for 4.0, but if so can be easily applied there as well.

Thanks for your contribution!

Mike Miller <mtmiller>
Group Member
Thu 15 Jan 2015 04:32:54 PM UTC, comment #12: 

Well it's only a small patch and not really worth mentioning but it's possibly an incentive to do further contributions... Sebastian Schoeps <sebastian@schoeps.org>

Sebastian <sschoeps>
Thu 15 Jan 2015 05:44:37 AM UTC, comment #11: 

Ok, I'm able to build with a slightly tweaked patch applied, both with and without the --without-fltk option. Both work as expected with libfltk1.3-dev fully installed, so it looks to me like it works. Sebastian, let me know if/how you want to be credited and I will push this to the default branch.

Mike Miller <mtmiller>
Group Member
Thu 15 Jan 2015 04:55:13 AM UTC, comment #10: 

Yes, sorry for the incredible delay getting back to this one. I fixed a couple of minor typos, doing a couple test builds now. I'll follow up when it's done building with and without this option.

Sebastian, do you want to be credited for this patch as "fullname <email>"? Fill in the blanks for me if so.

Mike Miller <mtmiller>
Group Member
Sun 28 Dec 2014 03:31:16 PM UTC, comment #9: 

@Mike: Do you have time to review this patch about adding a new --without-fltk switch to configure?

Rik <rik5>
Group administrator
Sat 26 Apr 2014 09:07:00 AM UTC, comment #8: 

Dear Mike, did you check the new patch? Seb.

Sebastian <sschoeps>
Fri 18 Apr 2014 04:03:16 PM UTC, comment #7: 

Building Octave with '--without-opengl' but with Qt does not work for me.

I have updated the patch at https://gist.github.com/schoeps/11035598  to work with "--without-fltk"  instead of "--disable-fltk". I am testing it right now.

Sebastian <sschoeps>
Fri 18 Apr 2014 01:37:31 PM UTC, comment #6: 

Not that OpenGL is now required but that it is used for both FLTK and for Qt plotting and for the common code used by both.

I have not done a test build yet to see what would happen now if Octave were built with '--without-opengl' but with Qt.

Have you done test builds with your configure patch to make sure all the cases are covered? Also why AC_ARG_ENABLE instead of AC_ARG_WITH? I think the latter would be preferred. We use --disable for features (gui, jit) and --with for libraries (fftw3, fltk).

Mike Miller <mtmiller>
Group Member
Fri 18 Apr 2014 10:41:47 AM UTC, comment #5: 

I suggest to reconsider the "--without-fltk". The current development version (GUI branch) seems to require opengl but FLTK is optional. Hence separate switches seem reasonable to me. I have updated the patch, see here: https://gist.github.com/schoeps/11035598.

Sebastian <sschoeps>
Wed 28 Nov 2012 07:16:15 PM UTC, comment #4: 

Closing this report, no response in 10 days.

Jordi Gutiérrez Hermoso <jordigh>
Group Member
Mon 19 Nov 2012 04:11:50 PM UTC, comment #3: 

It's a bit of a problem that we repeatedly refer to the OpenGL graphics by the toolkit we happen to have used to provide a windowing system for it: fltk. The interesting part is that we use OpenGL, not that we happen to use fltk as a windowing system right now; fltk was one of those "temporary" things we put in place until we had something better.

I don't know if you care, but we could use some help integrating this into Octave:

https://github.com/goffioul/QtHandles

Essentially, this is a more fully-featured interface to te OpenGL plotting engine that uses Qt instead of fltk for the widgets.

Do you have some suggested wording for configure.ac about how to indicate that the OpenGL graphics currently happen to require fltk?

Jordi Gutiérrez Hermoso <jordigh>
Group Member
Mon 19 Nov 2012 04:06:42 PM UTC, comment #2: 

I didn't make the connection between fltk and opengl. Indeed, my patch is not necessary - please close the bug. (I suppose one needs to know that "native graphics" = "fltk with opengl" - maybe a comment in configure.ac would be useful?)

Patrick Welche <prlw1>
Mon 19 Nov 2012 01:44:55 PM UTC, comment #1: 

I don't understand. How is this different from --without-opengl?

Jordi Gutiérrez Hermoso <jordigh>
Group Member
Mon 19 Nov 2012 12:45:37 PM UTC, original submission:  

Make it possible to build octave without FLTK support even if FLTK
is installed.

Patrick Welche <prlw1>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

Attached Files
file #26931:  0001-Add-disable-fltk-switch-to-configure.patch added by prlw1 (5KiB - application/octet-stream - Add --disable-fltk switch to configure)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by rik5 (Posted a comment)
  • -email is unavailable- added by mtmiller (Posted a comment)
  • -email is unavailable- added by sschoeps (Posted a comment)
  • -email is unavailable- added by jordigh (Posted a comment)
  • -email is unavailable- added by prlw1 (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only group members can vote.

     

    Follow 14 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2015-01-16 mtmiller StatusIn Progress Fixed
        Open/ClosedOpen Closed
    2015-01-15 mtmiller StatusPatch Submitted In Progress
        Assigned toNone mtmiller
    2014-12-28 rik5 StatusNeed Info Patch Submitted
    2014-04-18 mtmiller Severity3 - Normal 1 - Wish
        Release3.6.3 dev
        SummaryAdd --disable-fltk switch to configure Add --without-fltk switch to configure
    2014-04-18 mtmiller StatusInvalid / Not an Octave Bug Need Info
        Open/ClosedClosed Open
    2012-11-28 jordigh StatusPatch Submitted Invalid / Not an Octave Bug
        Open/ClosedOpen Closed
    2012-11-19 jordigh StatusNone Patch Submitted
    2012-11-19 prlw1 Attached File- Added 0001-Add-disable-fltk-switch-to-configure.patch, #26931

    Back to the top

    Powered by Savane 3.13-f8d8.
    Corresponding source code