bugGNU GRUB - Bugs: bug #37738, Gets is a security hole

 
 

You are not allowed to post comments on this tracker with your current authentication level.

bug #37738: Gets is a security hole

Submitted by:  WorMzy Tykashi <wormzy>
Submitted on:  Thu 15 Nov 2012 03:02:57 AM UTC  
 
Category:  Compilation Severity:  Major
Priority:  5 - Normal Item Group:  Action Request
Status:  Fixed Privacy:  Public
Assigned to:  Colin Watson <cjwatson> Originator Name: 
Open/Closed:  Closed Release: 
Release:  Bazaar - trunk Reproducibility:  Every Time
Planned Release:  None

Fri 28 Dec 2012 06:48:23 AM UTC, comment #1:

Fixed in trunk, thanks.

2012-12-28 Colin Watson <cjwatson@ubuntu.com>

Backport gnulib fixes for C11. Fixes Savannah bug #37738.

* grub-core/gnulib/stdio.in.h (gets): Warn on use only if
HAVE_RAW_DECL_GETS.
* m4/stdio_h.m4 (gl_STDIO_H): Check for gets.

Colin Watson <cjwatson>
Project MemberIn charge of this item.
Thu 15 Nov 2012 03:02:57 AM UTC, original submission:

Compiling grub2 with glibc 2.16 results in a compilation failure due to 'gets' undeclaration:-

x86_64-unknown-linux-gnu-gcc -DHAVE_CONFIG_H -I. -I../.. -I../../intl -MT argp-eexst.o -MD -MP -MF .deps/argp-eexst.Tpo -c -o argp-eexst.o argp-eexst.c
In file included from argp.h:22:0,
from argp-eexst.c:25:
./stdio.h:456:1: error: 'gets' undeclared here (not in a function)

-----

Working solution is to remove line 144 --

_GL_WARN_ON_USE (gets, "gets is a security hole - use fgets instead");

-- from grub/grub-core/gnulib/stdio.in.h in svn.

Building on Arch Linux.

glibc - 2.16.0
gettext - 0.18.1.1
autoconf - 2.69
automake - 1.12.4
binutils - 2.23
gcc - 4.7.2
libtool - 2.4.2
m4 1.4.16
make - 3.82
pkg-config - 0.27.1

WorMzy Tykashi <wormzy>

 

Attached Files
file #26913:  build.log added by wormzy (50KiB - text/x-log - Build log of unsuccessful build)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by cjwatson (Posted a comment)
  • -email is unavailable- added by wormzy (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

     

     

    Follow 4 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2012-12-28 cjwatson StatusNone => Fixed
        Assigned toNone => cjwatson
        Open/ClosedOpen => Closed
    2012-11-15 wormzy Attached File- => Added build.log, #26913

    Back to the top


    Powered by Savane 3.3