bugGNU Parallel - build and execute command lines from standard input in parallel - Bugs: bug #37657, FreeBSD patch for max args (-n)

 
 

bug #37657: FreeBSD patch for max args (-n)

Submitted by:  None
Submitted on:  Thu 01 Nov 2012 03:14:23 PM UTC  
 
Category: NoneSeverity: 3 - Normal
Item Group: NoneStatus: Need Info
Privacy: PublicAssigned to: None
Open/Closed: Closed

Add a New Comment (Rich MarkupRich Markup):
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Thu 24 Jan 2013 11:46:37 PM UTC, comment #2:

Info needed but not received for 2 months => closing bug.

Re-open the bug when the needed info is received.

Ole Tange <tange>
Project Administrator
Mon 26 Nov 2012 10:04:57 PM UTC, comment #1:

The patch seems to break arg max on other platforms.

A patch that does not break other platforms may be accepted.

Ole Tange <tange>
Project Administrator
Thu 01 Nov 2012 03:14:23 PM UTC, original submission:

Since FreeBSD has get_conf ARGS_MAX, might as well use it.

patch currently used by port:

------------
--- ./src/parallel.orig 2012-08-22 21:25:08.000000000 -0500
+++ ./src/parallel 2012-08-22 21:25:24.000000000 -0500
@@ -4571,21 +4571,15 @@
# Returns:
# number of chars on the longest command line allowed
if(not $Limits::Command::line_max_len) {
+ $Limits::Command::line_max_len = `getconf ARG_MAX` - 1024;
if($::opt_s) {
- if(is_acceptable_command_line_length($::opt_s)) {
- $Limits::Command::line_max_len = $::opt_s;
- } else {
- # -s is too long: Find the correct
- $Limits::Command::line_max_len = binary_find_max_length(0,$::opt_s);
+ if($::opt_s > $Limits::Command::line_max_len) {
+ print STDERR "$Global::progname: ",
+ "you are setting value for -s greater than $Limits::Command::line_max_len\n";
}
if($::opt_s <= $Limits::Command::line_max_len) {
$Limits::Command::line_max_len = $::opt_s;
- } else {
- ::warning("Value for -s option ",
- "should be < $Limits::Command::line_max_len.\n");
}
- } else {
- $Limits::Command::line_max_len = real_max_length();
}
}
return $Limits::Command::line_max_len;
--------------

Link to latest:
http://www.freebsd.org/cgi/cvsweb.cgi/ports/sysutils/parallel/files/

Anonymous

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by tange (Posted a comment)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 2 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Thu 24 Jan 2013 11:46:37 PM UTCtangeOpen/ClosedOpen=>Closed
    Mon 26 Nov 2012 10:04:57 PM UTCtangeStatusNone=>Need Info

    Back to the top


    Powered by Savane 3.1-cleanup