bugGNU Wget - Bugs: bug #37581, [PATCH] Fixing recursion resource...

 
 

bug #37581: [PATCH] Fixing recursion resource expiration problem.

Submitter:  John Peterson <john_peterson>
Submitted:  Tue 16 Oct 2012 04:16:37 PM UTC
   
 
Category:  Program Logic Severity:  3 - Normal
Priority:  5 - Normal Status:  None
Privacy:  Public Assigned to:  None
Originator Name:  Open/Closed:  Open
Release:  trunk Operating System:  GNU/Linux
Reproducibility:  Every Time Fixed Release:  None
Planned Release:  None Regression:  No
Work Required:  None Patch Included:  Yes
* Mandatory Fields

Add a New Comment Rich Markup
   

Fri 02 Jan 2015 01:06:14 AM UTC, comment #4: 

## making it optional

>To get your patch into git please add a command-line option to activate LIFO behavior.


k the patch is changed here https://github.com/mirror/wget/pull/1

the patch file is https://github.com/mirror/wget/pull/1.patch

John Peterson <john_peterson>
Thu 01 Jan 2015 08:20:19 PM UTC, comment #3: 

I am not sure why you expect that all the resources from 60 "branches" can be downloaded in less than 60s when the "branches" itself can't. But that does not really matter.

We simply can't change the default behavior of Wget for everyone just because you have a benefit. We have to be very conservative when touching default behavior.

To get your patch into git please add a command-line option to activate LIFO behavior.
Like e.g. --queuing=[FIFO|LIFO] with FIFO as default.

What do you think ?

Tim Ruehsen <rockdaboot>
Group administrator
Thu 27 Dec 2012 12:35:37 AM UTC, comment #2: 

Patch moved.

John Peterson <john_peterson>
Sat 08 Dec 2012 06:21:01 PM UTC, comment #1: 

Patch moved.

John Peterson <john_peterson>
Tue 16 Oct 2012 04:16:37 PM UTC, original submission:  

0001-Fixing-recursion-resource-expiration-problem.patch

Changing recursion collection from fifo to lifo to download recursion branch page resources immediately following the branch page download.

Test case: The level 0 page has >60 branches that takes 1 s each to download and whose resources expire in 60 s. The fifo queue download all branch pages before downloading any branch page resources. The branch page resources have expired by the time they are to be downloaded.

Thanks!

John Peterson <john_peterson>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by rockdaboot (Posted a comment)
  • -email is unavailable- added by john_peterson (Submitted the item)
  •  

    No changes have been made to this item

    Back to the top

    Powered by Savane 3.13-cf05.
    Corresponding source code