Sun 03 Jun 2012 08:52:55 PM UTC, comment #2:
Yep. Angel Gonzalez was able to fix it! He submitted a patch to the bug-wget list, viewable here:
http://git.savannah.gnu.org/cgit/wget.git/commit/?id=ee9d4a905769c7bdfad94947c48aaada329fc9de
I can confirm that the test case described below now works. Thanks a million Angel! I don't see an option to close the bug, but the fix submitted works. Consider bug closed :D
Angel Gonzalez's fix:
diff --git a/ChangeLog b/ChangeLog
index aa249b0..2f0f965 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,7 @@
+2012-05-31 Ángel González <keisial@gmail.com>
+
+ * convert.c: fix segfault on wrong urls (bug 36570)
+
2012-05-13 Giuseppe Scrivano <gscrivano@gnu.org>
- bootstrap.conf (gnulib_modules): Add `git-version-gen'.
diff --git a/src/convert.c b/src/convert.c
index e1c58e9..f5a9cba 100644
--- a/src/convert.c
+++ b/src/convert.c
@@ -124,6 +124,9 @@ convert_links_in_hashtable (struct hash_table *downloaded_set,
set_uri_encoding (pi, opt.locale, true);
u = url_parse (cur_url->url->url, NULL, pi, true);
+ if (!u)
+ continue;
+
local_name = hash_table_get (dl_url_file_map, u->url);
/* Decide on the conversion type. */
|