bugGNU Octave - Bugs: bug #36469, pkg load can't deal with circular...

 
 

bug #36469: pkg load can't deal with circular dependencies

Submitter:  Carnë Draug <carandraug>
Submitted:  Mon 14 May 2012 10:06:20 PM UTC
   
 
Category:  None Severity:  3 - Normal
Priority:  5 - Normal Item Group:  None
Status:  Fixed Assigned to:  mtmiller
Originator Name:  Open/Closed:  * Closed
Release:  * dev Operating System:  * Any
Fixed Release:  None Planned Release:  None
* Mandatory Fields

Add a New Comment Rich Markup
   

Mon 21 May 2012 11:32:47 AM UTC, comment #3: 

Sorry for taking so long to test this change. It indeed solves the problem. Thank you

When testing this I noticed another bug on the pkg system when unloading packages. Packages that are dependent on the package being unloaded are not unloaded and no warning is given. I'll open a separate bug report for that.

Carnë Draug <carandraug>
Group Member
Sat 19 May 2012 03:40:56 PM UTC, comment #2: 

Ok, I pushed this after getting some time to test a few cases.  This feature will be available in Octave 3.8.x.

http://hg.savannah.gnu.org/hgweb/octave/rev/dee1452ca601

As a side effect, the path ordering between sibling dependencies of a package now matches the ordering in the package Depends line.

Mike Miller <mtmiller>
Group Member
Thu 17 May 2012 01:01:02 PM UTC, comment #1: 

Can you try this patch and confirm that it works for your test cases?

(file #25872)

Mike Miller <mtmiller>
Group Member
Mon 14 May 2012 10:06:20 PM UTC, original submission:  

Hi

when there's 2 packages, each of them depending on each other, pkg load will enter into a recursive loop and give a max_recursion_depth exceeded error. pkg install does not have that problem (provided both packages are given at the time of installation).

Basically, if pkg1 and pkg2 depend on one another:

## both fail (missing dependency)
pkg install pkg1.tar.gz
pkg install pkg2.tar.gz
## works fine
pkg install pkg1.tar.gz pkg2.tar.gz
## returns error
pkg load pkg1 pkg2


A temporary workaround for this is to load the packages with the -nodeps flag.

I'll have to look into this code better when I get time but I was thinking of looking into whatever pkg install is doing to solve the dependencies, and adapt it for pkg load.

Carnë

Carnë Draug <carandraug>
Group Member

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

Attached Files

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by mtmiller (Updated the item)
  • -email is unavailable- added by carandraug (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only group members can vote.

     

    Follow 6 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2012-05-19 mtmiller StatusPatch Submitted Fixed
        Open/ClosedOpen Closed
        Release3.6.1 dev
    2012-05-17 mtmiller Attached File- Added pkg-load-circular-deps.patch, #25872
        StatusNone Patch Submitted
        Assigned toNone mtmiller

    Back to the top

    Powered by Savane 3.13-758e.
    Corresponding source code