bugGNU recutils - Bugs: bug #35742, Unsafe include guards

 
 

bug #35742: Unsafe include guards

Submitter:  Markus Elfring <elfring>
Submitted:  Wed 07 Mar 2012 02:50:31 PM UTC
   
 
Category:  librec Severity:  3 - Normal
Item Group:  None Status:  Fixed
Privacy:  Public Assigned to:  jemarch
Open/Closed:  Closed
* Mandatory Fields

Add a New Comment Rich Markup
   

Tue 13 Mar 2012 09:17:25 PM UTC, comment #2: 

I would prefer longer identifiers. Would you like to make all include guards really unique?

Markus Elfring <elfring>
Tue 13 Mar 2012 08:44:31 PM UTC, comment #1: 

Hi.

I changed the REC_H guard to read GNU_REC_H.  Regarding rec-utils.h, that header file is not installed, so there is no reason to change the general rule used to name the guards.

Thanks for the report.

Jose E. Marchesi <jemarch>
Group administrator
Wed 07 Mar 2012 02:50:31 PM UTC, original submission:  

I find your include guards "REC_H" and REC_UTILS_H too short.
How do you think about to add an UUID to them so that the reuse of the header files will become safer?

Markus Elfring <elfring>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by jemarch (Posted a comment)
  • -email is unavailable- added by elfring (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only logged-in users can vote.

     

    Follow 3 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2012-03-13 jemarch StatusNone Fixed
        Assigned toNone jemarch
        Open/ClosedOpen Closed

    Back to the top

    Powered by Savane 3.13-4448.
    Corresponding source code