bugGNU Octave - Bugs: bug #34907, legend displaynames on fltk

 
 

bug #34907: legend displaynames on fltk

Submitter:  Ben Abbott <bpabbott>
Submitted:  Sat 26 Nov 2011 06:19:02 PM UTC
   
 
Category:  Plotting with OpenGL Severity:  5 - Blocker
Priority:  5 - Normal Item Group:  Incorrect Result
Status:  Fixed Assigned to:  None
Originator Name:  Open/Closed:  * Closed
Release:  * dev Operating System:  * Any
Fixed Release:  None Planned Release:  None
* Mandatory Fields

Add a New Comment Rich Markup
   

Jump to the original submission

Mon 16 Jul 2012 07:07:04 PM UTC, comment #10: 

The fix got applied for 3.8.0. If you're in a hurry, you can either build from Mercurial or attempt to backport the fix to the stable release.

Jordi GutiƩrrez Hermoso <jordigh>
Group Member
Mon 16 Jul 2012 05:37:16 PM UTC, comment #9: 

first thanks for the bug fixing !

any idea when this will be available in the "standard" source ?
I am using 3.6.2 on Ubuntu (the current "up-to-date" available download) and this problem is showing up.

Was the problem fixed in 3.6.x ?

Thx !

Fab.

foehler <foehler>
Thu 15 Mar 2012 10:52:01 PM UTC, comment #8: 
Ben Abbott <bpabbott>
Group Member
Thu 15 Mar 2012 08:18:10 PM UTC, comment #7: 

Kostas,

I've attached a changeset. I'll test it later and push it if all goes well and there are no objections,

(file #25372)

Ben Abbott <bpabbott>
Group Member
Thu 15 Mar 2012 07:10:54 PM UTC, comment #6: 

Ben, sorry no time for writing a changelog could you please do the commit yourself? Just replace the line:

glRasterPos3d (pos(0), pos(1), pos(2));

with

glRasterPos3d (pos(0), pos(1), pos.numel () > 2 ? pos(2) : 0.0);

in the original patch with respect to gl-renderer.cc jwe has also changed the constness of pos but I don't know why. Maybe you could ask him.

Konstantinos Poulios <logari81>
Mon 12 Mar 2012 12:58:44 PM UTC, comment #5: 

Kostas,

Will you have time to fix this ?

Ben Abbott <bpabbott>
Group Member
Mon 12 Mar 2012 09:11:58 AM UTC, comment #4: 

I am reopenning this one because the same fix needs to be applied to gl2ps-renderer.cc, otherwise legend names are not displayed on printed plots.

Konstantinos Poulios <logari81>
Wed 30 Nov 2011 01:55:38 PM UTC, comment #3: 

the fix works for me as well.

thanks

Konstantinos Poulios <logari81>
Wed 30 Nov 2011 03:05:00 AM UTC, comment #2: 

Yes, your changeset fixed the problem for me.

I've set the status to "fixed" and closed the bug report.

Ben Abbott <bpabbott>
Group Member
Wed 30 Nov 2011 12:03:49 AM UTC, comment #1: 

I checked in the following changeset.

http://hg.savannah.gnu.org/hgweb/octave/rev/0fea4cf22f88

Let me know whether this change also fixes the problem for you.  If so the, I'll close the report.

John W. Eaton <jwe>
Group administrator
Sat 26 Nov 2011 06:19:02 PM UTC, original submission:  

I have just found a regression in the fltk backend. Legend text will not show up with the current default branch:


octave:1> graphics_toolkit fltk
octave:2> plot(0:5,0:5)
octave:3> legend('test text')


if this is confirmed and no one else is available for fixing it, I will do it before the 3.6 release.

Kostas

Ben Abbott <bpabbott>
Group Member

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

Attached Files
file #25372:  changeset.patch added by bpabbott (733B - application/octet-stream - first changeset)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by jordigh (Posted a comment)
  • -email is unavailable- added by foehler (Posted a comment)
  • -email is unavailable- added by rik5 (Updated the item)
  • -email is unavailable- added by logari81 (Posted a comment)
  • -email is unavailable- added by jwe (Posted a comment)
  • -email is unavailable- added by bpabbott (Submitted the item)
  • -email is unavailable- added by bpabbott (Kostas, I thought it best to add a bug report so that this doesn't get forgotten.)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only group members can vote.

     

    Follow 9 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2012-04-06 rik5 StatusIn Progress Fixed
        Open/ClosedOpen Closed
    2012-03-15 bpabbott Attached File- Added changeset.patch, #25372
    2012-03-12 logari81 StatusFixed In Progress
        Open/ClosedClosed Open
    2011-11-30 bpabbott StatusNone Fixed
        Open/ClosedOpen Closed
    2011-11-26 bpabbott Summarylegend displaynames legend displaynames on fltk
    2011-11-26 bpabbott Carbon-Copy- Added -email is unavailable-

    Back to the top

    Powered by Savane 3.13-4448.
    Corresponding source code