bugGnash - The GNU Flash player - Bugs: bug #31885, revno.h found in tarball is...

 
 

bug #31885: revno.h found in tarball is overridden with date on first make

Submitted by:  Sandro Santilli <strk>
Submitted on:  Wed 15 Dec 2010 07:46:50 AM UTC  
 
Category: buildSeverity: 3 - Normal
Release: masterStatus: None
Privacy: PublicAssigned to: Rob Savoye <rsavoye>
Open/Closed: Open

Add a New Comment (Rich MarkupRich Markup):
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Sat 18 Dec 2010 09:55:26 AM UTC, comment #4:

Where's the correct version number embedded ?
We're talking about snapshots tarballs too here.

Sandro Santilli <strk>
Project Member
Sat 18 Dec 2010 04:34:00 AM UTC, comment #3:

No, I want to differentiate between a build somebody does that built from a source tarball from somebody that installed one of the debs from our repository. Revno.h contains the correct information for all builds from git, and packages. If somebody has a date instead, we know where it came from. The version number is embedded elsewhere, so it's not like it's lost. Personally, I wouldn't even call this a bug, it's a feature. :-)

Now the usefulness of that feature, is probably open to polite discussion...But it actually works this way on purpose.

Rob Savoye <rsavoye>
Project AdministratorIn charge of this item.
Wed 15 Dec 2010 02:53:16 PM UTC, comment #2:

You mean you want gnash --version coming out from tarballs to tell meaningless things ?
How does it help debugging issues ?
Why are we using revno.h at all if it contains misleading informations ?

I belive this should be fixed before next release (thus blocker).

Sandro Santilli <strk>
Project Member
Wed 15 Dec 2010 02:50:30 PM UTC, comment #1:

That's how it's supposed to work.

Rob Savoye <rsavoye>
Project AdministratorIn charge of this item.
Wed 15 Dec 2010 07:46:50 AM UTC, original submission:

Getting gnash from the tarball created by 'make dist',
extracting, configuring and building, results in gnash --version
giving a date instead of branch name-num_commits-comit_id.

Haven't checked, but most likely running 'make dist' again
from this uncompressed tree would ship the bogus revno.h
in turn.

Sandro Santilli <strk>
Project Member

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by rsavoye (Updated the item)
  • -unavailable- added by strk (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follows 1 latest change.

    Date Changed By Updated Field Previous Value => Replaced By
    Wed 15 Dec 2010 02:50:30 PM UTCrsavoyeSeverity5 - Blocker=>3 - Normal

    Back to the top


    Powered by Savane 3.1-cleanup