bugGnash - The GNU Flash player - Bugs: bug #31782, KDE3 gui doesn't build

 
 

bug #31782: KDE3 gui doesn't build

Submitted by:  Sandro Santilli <strk>
Submitted on:  Sat 04 Dec 2010 09:05:23 PM UTC  
 
Category: gui-kde3Severity: 3 - Normal
Release: masterStatus: Ready For Test
Privacy: PublicAssigned to: Sandro Santilli <strk>
Open/Closed: Open

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Fri 15 Apr 2011 05:48:45 AM UTC, comment #5:

The patch applied to git master. Now pushed to the public repository. See "Source Code"->"Use Git" for instructions about how to get the latest code and please try that one.

Sandro Santilli <strk>
Project MemberIn charge of this item.
Fri 15 Apr 2011 05:27:59 AM UTC, comment #4:

The patch - file 23245 - seems to apply to gui/qt/kde3.am
I do not have a gui/qt directory in my tarball, however I do have a gui/kde/kde3.am file ( the version I downloaded and am working with is gnash-0.8.9.tar.gz ) but your patch does not apply to that file.

Mike Bair <foresthillmike>
Thu 14 Apr 2011 07:31:33 PM UTC, comment #3:

Tested myself, patch actually fixes the build.
Pushed to master 66a4323

Sandro Santilli <strk>
Project MemberIn charge of this item.
Thu 14 Apr 2011 06:52:56 PM UTC, comment #2:

Good catch.
Could you try the attached patch ?
Drops many other duplicates too (and could likely be further streamlined).

(file #23245)

Sandro Santilli <strk>
Project MemberIn charge of this item.
Thu 14 Apr 2011 05:04:46 PM UTC, comment #1:

The problem is in the gui/Makefile
line 675 kde3_gnash-kde.$(OBJEXT) for am__objects_18 is a duplicate of line 673 for am__objects_17 - so the file kde3_gnash-kde.o gets included twice when am_kde3_gnash_OBJECTS ( line 676 ) executes

Suggest removing line 675

Mike Bair <foresthillmike>
Sat 04 Dec 2010 09:05:23 PM UTC, original submission:

kde3 is attempted to build if deps are found currently.
Rob mentioned it wouldn't have worked if both kde3 and kde4 were enabled.
In any case, even exclusively enabling kde3 (--enable-gui=kde3) doesn't help.

Mostly, errors are duplicated definitions:

/usr/include/qt3/qglist.h:154: multiple definition of `gnash::qwidget::className() const'
kde3_gnash-kde.o:/usr/include/qt3/qglist.h:154: first defined here

weird message indeed. no idea what it is.

Sandro Santilli <strk>
Project MemberIn charge of this item.

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files
file #23245:  gnash.kde3.patch added by strk (1KiB - text/x-patch)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by foresthillmike (Posted a comment)
  • -unavailable- added by strk (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 4 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Thu 14 Apr 2011 07:31:33 PM UTCstrkStatusIn Progress=>Ready For Test
    Thu 14 Apr 2011 06:52:56 PM UTCstrkAttached File-=>Added gnash.kde3.patch, #23245
      StatusNone=>In Progress
      Assigned toNone=>strk

    Back to the top


    Powered by Savane 3.1-cleanup1