bugPSPP - Bugs: bug #31016, Crash parsing arguments to DO...

 
 

bug #31016: Crash parsing arguments to DO REPEAT.

Submitter:  John Darrington <jmd>
Submitted:  Sat 11 Sep 2010 09:04:50 AM UTC
   
 
Category:  Syntax Parser Severity:  7 - Major
Status:  Fixed Assigned to:  None
Open/Closed:  Closed Release:  None
Effort:  0.00
* Mandatory Fields

Add a New Comment Rich Markup
   

Tue 28 Sep 2010 01:57:40 AM UTC, comment #2: 

I pushed a fix for this bug (different from the one submitted by Terry).

Ben Pfaff <blp>
Group administrator
Mon 27 Sep 2010 09:04:18 PM UTC, comment #1: 

As far as I can tell, there are two issues with this bug.

First,

I believe crash.sps has a syntax error on line 27.

Instead of     '   end do.',

it should be   '   end repeat.'

Making this change to crash.sps makes the program run properly.

Second,

pspp is not properly handling the invalid syntax. For that, I have attached a patch file (crash.patch) to the source which changes pspp to properly detect the invalid syntax and output the offending line.

To apply the patch:

cd pspp-0.7.5-g8a0397
patch -p1 < crash.patch



(file #21558)

Terry W Droeger <tdroeger>
Sat 11 Sep 2010 09:04:50 AM UTC, original submission:  

This syntax in the attached file causes an assertion failure in the lexer.



John Darrington <jmd>
Group administrator

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

Attached Files
file #21558:  crash.patch added by tdroeger (2KiB - text/x-patch - Here is a patch file that provides a fix)
file #21434:  crash.sps added by jmd (347B - application/octet-stream)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by blp (Posted a comment)
  • -email is unavailable- added by tdroeger (Updated the item)
  • -email is unavailable- added by jmd (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only logged-in users can vote.

     

    Follow 4 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2010-09-28 blp StatusNone Fixed
        Open/ClosedOpen Closed
    2010-09-27 tdroeger Attached File- Added crash.patch, #21558
    2010-09-11 jmd Attached File- Added crash.sps, #21434

    Back to the top

    Powered by Savane 3.13-4448.
    Corresponding source code