bugGNU Octave - Bugs: bug #30767, Periodogram - extend functionality

 
 

bug #30767: Periodogram - extend functionality

Submitter:  Alois Schlögl <schloegl>
Submitted:  Fri 13 Aug 2010 10:43:02 AM UTC
   
 
Category:  Libraries Severity:  3 - Normal
Priority:  5 - Normal Item Group:  Feature Request
Status:  Fixed Assigned to:  None
Originator Name:  Open/Closed:  * Closed
Release:  * dev Operating System:  * GNU/Linux
Fixed Release:  None Planned Release:  None
* Mandatory Fields

Add a New Comment Rich Markup
   

Jump to the original submission

Thu 16 Sep 2010 05:38:48 AM UTC, comment #7: 

I made the change.

Jaroslav Hajek <highegg>
Thu 02 Sep 2010 07:16:21 PM UTC, comment #6: 

You're not a very careful reader, then :) (admittedly, it's quite tersely written)

"When calling functions, put spaces after commas and before the calling parentheses"

"Enclose the if, while, until and switch conditions in parentheses, like in C"




Jaroslav Hajek <highegg>
Thu 02 Sep 2010 04:27:52 PM UTC, comment #5: 

I read "Appendix D Contributing Guidelines"
http://www.gnu.org/software/octave//doc/interpreter/Contributing-Guidelines.html#Contributing-Guidelines

The only required change, I see is "end % if" -> "endif"
This file is attached.

A diff patch is not applicable, because it really modifies all existing code.

CHANGELOG
2010-09-02 Alois Schloegl <alois.schloegl@gmail.com>
     The attached version extends the functionality of
     periodogram.m, adds support for additional input 
     parameters, including, win, nfft, Fs and range.
     This makes it compatible with the interface of ml.



(file #21377)

Alois Schlögl <schloegl>
Wed 01 Sep 2010 07:33:49 AM UTC, comment #4: 

The most important ones are in the manual, section "Contributing Guidelines".

Jaroslav Hajek <highegg>
Tue 31 Aug 2010 11:40:03 AM UTC, comment #3: 


It's better you fix it. There are no specific suggestions telling me which changes are necessary.

   Alois


Alois Schlögl <schloegl>
Tue 31 Aug 2010 06:22:45 AM UTC, comment #2: 

Yes, that would speed things up. I intend to polish it myself eventually, but still haven't got to it...

Jaroslav Hajek <highegg>
Sun 29 Aug 2010 02:32:15 PM UTC, comment #1: 

If you want this function to replace the current version in Octave, then please edit it to follow the coding conventions used in the rest of Octave.

John W. Eaton <jwe>
Group administrator
Fri 13 Aug 2010 10:43:02 AM UTC, original submission:  

The attached version extends the functionality of
periodogram.m, adds support for additional input parameters, including, win, nfft, Fs and range. This makes it compatible with the interface of ml.

The following tests have been performed and show equivalent results (difference is less than a few eps).


x=mod(1:10,3)'-1;
periodogram(x)
Pxx=periodogram(x)
size(Pxx)

Pxx=periodogram(x,[],10)  
[Pxx,w]=periodogram(x,[],10)  
[Pxx,f]=periodogram(x,[],10,[])  
[Pxx,f]=periodogram(x,[],10,100)  
[Pxx,f]=periodogram(x,[],'twosided',10,100)  


 x=mod(1:1001,3)'-1;
 periodogram(x)
 Pxx=periodogram(x)
 size(Pxx)

 x=mod(1:1024,3)'-1;
 periodogram(x)
 Pxx=periodogram(x)
 size(Pxx)


A similar patch has been submitted here,
  https://savannah.gnu.org/patch/?7236
Obviously, it has not been processed and would be obsolete by now. 


 Alois


Alois Schlögl <schloegl>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

Attached Files
file #21377:  periodogram.m added by schloegl (5KiB - text/x-objcsrc)
file #21210:  periodogram.m added by schloegl (5KiB - text/x-objcsrc)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by siko1056 (Updated the item)
  • -email is unavailable- added by jwe (Posted a comment)
  • -email is unavailable- added by highegg (Updated the item)
  • -email is unavailable- added by schloegl (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only group members can vote.

     

    Follow 8 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2015-09-28 siko1056 StatusPatch Submitted Fixed
        Assigned tohighegg None
    2010-09-16 highegg CategoryNone Libraries
        StatusNone Patch Submitted
        Open/ClosedOpen Closed
    2010-09-02 schloegl Attached File- Added periodogram.m, #21377
    2010-08-17 highegg Assigned toNone highegg
    2010-08-13 schloegl Attached File- Added periodogram.m, #21210

    Back to the top

    Powered by Savane 3.13-d3ae.
    Corresponding source code