bugphpGroupWare - Bugs: bug #30631, Recurring exceptions not updated...

 
 

You are not allowed to post comments on this tracker with your current authentication level.

bug #30631: Recurring exceptions not updated on event change

Submitted by:  Adam Cornett <acornett>
Submitted on:  Mon 02 Aug 2010 06:56:48 PM UTC  
 
Item Group:  None Category:  calendar
Severity:  3 - Normal Priority:  5 - Normal
Status:  Ready For Test Privacy:  Public
Assigned to:  Caeies <Caeies> Open/Closed:  Open
Component Version:  None Operating System:  GNU/Linux - Ubuntu
Reproducibility:  Every Time Planned Release:  None
Fixed Release: 

Wed 11 Aug 2010 02:45:41 PM UTC, comment #3:

Btw,

I just made a test on the Google calendar application and they proceed as phpgroupware is proceeding : in case of a change in the recurring event, all removed events are put back in the calendar. So it could look like "not a bug but a feature" ...

I won't commit it before a serious discussion takes place on this.

Regards,

Caeies

Caeies <Caeies>
Project AdministratorIn charge of this item.
Wed 11 Aug 2010 11:35:31 AM UTC, comment #2:

Hi Adam,

Well, from what I read in the code, yes, recur_exception field is not updated ...

I agree that in some cases, people want the exceptions to be kept as is, even if the hours are changed, but if days are changed what should we do ?

Anyway, this is a rough first try to fix this issue. Please test it on your local installation and tell me if :
- nothing else is broken in your day to day use of calendar,
- if the patch is working for you.

I take a really simplistic approach, I hope this is the good one :).

If some other dev can take a look at it and comment :).

Regards.

Caeies

(file #21191)

Caeies <Caeies>
Project AdministratorIn charge of this item.
Wed 11 Aug 2010 09:19:42 AM UTC, comment #1:

Hi Adam,

Thanks for your input, I'm working on it.

Regards,

Caeies.

Caeies <Caeies>
Project AdministratorIn charge of this item.
Mon 02 Aug 2010 06:56:48 PM UTC, original submission:

The exception dates for a recurring event are not updated when an event is changed.
Steps to reproduce:
- Create an even that repeats weekly, say every Monday at 9am.
- Remove one instance of the event in the future.
- Change the time of the series to 9:30am
- The removed instance now displays on the calendar.

I have looked into it and it seems that the unix time stamps listed in the recur_exception field of the phpgw_cal_repeats table are not changed when the event is edited.

Adam Cornett <acornett>

 

Attached Files
file #21191:  patch_calendar_fix_30631.diff added by Caeies (3KiB - text/x-patch - first patch for testing and review purposes.)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by Caeies (Posted a comment)
  • -email is unavailable- added by acornett (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 4 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2010-08-11 Caeies Attached File- => Added patch_calendar_fix_30631.diff, #21191
        StatusConfirmed => Ready For Test
    2010-08-11 Caeies StatusNone => Confirmed
    2010-08-11 Caeies Assigned toNone => Caeies

    Back to the top


    Powered by Savane 3.3