bugGNUstep - Bugs: bug #30538, X11 backend should generate...

Group
 
 

bug #30538: X11 backend should generate NSBackTabCharacter for shift-tab

Submitter:  Derek Fawcus <dfawcus>
Submitted:  Sat 24 Jul 2010 11:18:10 AM UTC
   
 
Category:  Backend Severity:  3 - Normal
Item Group:  Bug Status:  Ready For Test
Privacy:  Public Assigned to:  FredKiefer
Open/Closed:  In Test
* Mandatory Fields

Add a New Comment Rich Markup
   

Mon 14 Nov 2011 01:34:04 PM UTC, comment #3: 

We are near a gui+back release. Can this bug fix be confirmed by the original author?

Riccardo Mottola <rmottola>
Group Member
Mon 26 Jul 2010 08:06:46 PM UTC, comment #2: 

The discussion of this item was moved on to the mailing list. I just copy in Derek's latest reply, so it isn't lost although I wont address it at the moment:

Looking at your commit comments,  I do have a question and further suggestion.

    "Also use NSBackTabCharacter on X11 when XK_ISO_Left_Tab is
     pressed, but don't convert shift-tab into NSBackTabCharacter."

Now my patch didn't have any code in back to map shift+XK_Tab to backtab.
However,  I think it would be a good idea.  So why not add it?

It is possible some X installations don't have XK_ISO_Left_Tab,  and (in back)
it is conditional upon XKB support.  At least one VNC server omits XKB support.

Having the back ends do the mapping would also allow it to be removed
from the code in NSBrowser,NSInputManager,NSWindow,NSMatrix which checks
for Tab+shift.


Fred Kiefer <FredKiefer>
Group Member
Sun 25 Jul 2010 08:58:48 PM UTC, comment #1: 

Could you please explain the benefit of this change? I just added support for NSBackTabCharacter into gui, so the basic gui code wont stop working as soon as this patch gets applied. But this also requires that every application out there that has special handling for tab and shift-tab build in will have to add a special case for backtab as well.
Before we go out and break all these application we should know whether it is worth it.

Fred Kiefer <FredKiefer>
Group Member
Sat 24 Jul 2010 11:18:10 AM UTC, original submission:  

The code sort of has support for this,  but it ends up mapping the backtab keysym to a normal tab.

The suggested diff is:

--- a/Source/x11/XGServerEvent.m
+++ b/Source/x11/XGServerEvent.m
@@ -2292,7 +2292,7 @@ process_char (KeySym keysym, unsigned *eventModifierFlags)
     case XK_Linefeed:     return NSFormFeedCharacter;
     case XK_Tab:          return NSTabCharacter;
 #ifdef XK_XKB_KEYS
-    case XK_ISO_Left_Tab: return NSTabCharacter;
+    case XK_ISO_Left_Tab: return NSBackTabCharacter;
 #endif
       /* FIXME: The following line ? */
     case XK_Escape:       return 0x1b;

Derek Fawcus <dfawcus>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by rmottola (Posted a comment)
  • -email is unavailable- added by FredKiefer (Posted a comment)
  • -email is unavailable- added by dfawcus (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only logged-in users can vote.

     

    Follow 4 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2010-07-26 FredKiefer StatusNeed Info Ready For Test
        Open/ClosedOpen In Test
    2010-07-25 FredKiefer StatusNone Need Info
        Assigned toNone FredKiefer

    Back to the top

    Powered by Savane 3.13-758e.
    Corresponding source code