bugDenemo - Bugs: bug #30435, View menu checklist states don't...

 
 

bug #30435: View menu checklist states don't load on save

Submitter:  None
Submitted:  Tue 13 Jul 2010 05:29:56 PM UTC
   
 
Category:  Feature request
Severity:  3 - Normal Item Group:  None
Status:  Fixed Privacy:  Public
Assigned to:  rshann Originator Name: 
Open/Closed:  Closed
* Mandatory Fields

Add a New Comment Rich Markup
   

Jump to the original submission

Tue 10 Aug 2010 10:21:01 AM UTC, comment #6: 

there is now a pref called persistence

Richard Shann <rshann>
Group administrator
Fri 30 Jul 2010 03:52:34 PM UTC, comment #5: 

Well I guess the solution is, as always, to make it a pref. I will bundle this with opening the last opened file as well, as this is something which comes into a similar category.

Richard Shann <rshann>
Group administrator
Fri 30 Jul 2010 01:05:03 PM UTC, comment #4: 

I am not so sure that folks wouldn't prefer the choices to persist, in fact, I am not sure which way I would vote. Do some of them persist?

Richard Shann <rshann>
Group administrator
Fri 30 Jul 2010 11:27:17 AM UTC, comment #3: 

This is not a bug. You choose how Denemo should look like in your Preferences and if you need something for a short time you activate/deactivate the checkbox without loosing your default layout.

-Deleted Account- <steele>
Fri 30 Jul 2010 02:07:28 AM UTC, comment #2: 

Looking around at the c source, I'm going to guess at where the problem lies.
In view.c we have a handful of functions like

static void
toggle_rhythm_toolbar (GtkAction * action, gpointer param)

which do only

 gtk_widget_show (widget);

or hide the widget.  These, I'm pretty sure, are the functions called from the view menu checklist.  However, when the preferences are loaded or saved, in prefops.c, it uses

  WRITEBOOLXMLENTRY(rhythm_palette)

and

  READBOOLXMLENTRY(rhythm_palette)

and these variables (rhythm_palette etc.) are NOT modified in toggle_rhythm_toolbar and similar functions.  My guess then is that just making these toggle_rhythmic_toolbar etc. functions in view.c also modify the variables rhythmic_palette etc. would do the trick.  I hope this helps make eliminating this problem quick and straightforward when you get around to it.-Dan W.

Anonymous
Fri 30 Jul 2010 01:24:02 AM UTC, comment #1: 

The problem more specifically is this.

There are two ways to check/uncheck things to include in the view.

One way is the view menu.  Checking/unchecking these things changes right then and there whether they're displayed or not.  However, when you exit and return to denemo, they're not saved.

The other way is the Edit->Change Preferences way.  You can check or uncheck boxes for different elements of the view, but it has no immediate effect.  However, when you exit denemo, this is saved and when denemo starts next time, it is all set how you wanted it.

So I assume there are two places where these variables are stored.  One determines what denemo does when it starts and is changed with Change Preferences and saved in denemorcV2; the other determines what denemo is doing at that given moment, is loaded from denemorcV2 and is changed in the View menu.  Eliminating this redundancy would solve the problem, unless I'm mistaken.
-Dan W

Anonymous
Tue 13 Jul 2010 05:29:56 PM UTC, original submission:  

On windows xp, with version 0.8.19, this still exists
-Dan

Anonymous

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by rshann (Posted a comment)
  • -email is unavailable- added by steele (Posted a comment)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only logged-in users can vote.

     

    Follow 8 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2010-12-04 steele Open/ClosedOpen Closed
    2010-08-10 rshann StatusIn Progress Fixed
    2010-07-30 rshann CategoryNone Feature request
        StatusInvalid In Progress
        Assigned toNone rshann
        Open/ClosedClosed Open
    2010-07-30 steele StatusNone Invalid
        Open/ClosedOpen Closed

    Back to the top

    Powered by Savane 3.12.
    Corresponding source code