bugGNUstep - Bugs: bug #29871, item size not respected in...

Group
 
 

bug #29871: item size not respected in NSToolBar (Search field in Grr)

Submitter:  Riccardo Mottola <rmottola>
Submitted:  Wed 12 May 2010 10:10:18 PM UTC
   
 
Category:  Gui/AppKit Severity:  3 - Normal
Item Group:  Change Request Status:  Fixed
Privacy:  Public Assigned to:  FredKiefer
Open/Closed:  Closed
* Mandatory Fields

Add a New Comment Rich Markup
   

Mon 17 May 2010 10:49:09 PM UTC, comment #3: 

I think the current behaviour is correct now. At least, Grr matches what Cocoa does.
I think we described it the last time correclty, btu perhaps we misunderstood each other, since I described the behaviour during the procedure of making things smaller.

First all white space is eaten up, then flexible items are gradually resize to their minimum, then items overflow.

Riccardo Mottola <rmottola>
Group Member
Thu 13 May 2010 04:31:04 PM UTC, comment #2: 

I changed the code to expand the flexible items first before expanding the flexible space. This feels correct, so I committed it. Please test this.

Fred Kiefer <FredKiefer>
Group Member
Thu 13 May 2010 02:36:19 PM UTC, comment #1: 

I just added code to SVN that handles the resizing of the toolbar a lot better. What we do not is when there isn't any flexible space in the toolbar, then all the items will be scaled up to there maximum size. (This only works for items backed up with a custom view at the moment)
Now in Grr we have a flexible space present in the toolbar. This results in no visible difference between the current code and the old one. To address this we will have to redefine the way toolbars resize their items. In a private communication a few months back we defined that first flexible spaces get resized and only if none is present the other items will resize.
What you are requesting now for Grr seems to be more in the line of: First resize all flexible items up to their maximum size and only if there is space left resize flexible spaces to fill this up.

Implementing this new behaviour isn't that difficult, but we first have to agree that this is really what we want. Perhaps I did misunderstand you at that time? I will try out the new behaviour and commit it if it feels correct.

Fred Kiefer <FredKiefer>
Group Member
Wed 12 May 2010 10:10:18 PM UTC, original submission:  

The search field in Grr does not instantiate in the correct size even if there is enough space for that.

Grr is available in gap and it should look like this:

http://multixden.blogspot.com/2010/02/grr-working-on-windows.html


Riccardo Mottola <rmottola>
Group Member

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by FredKiefer (Posted a comment)
  • -email is unavailable- added by rmottola (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only logged-in users can vote.

     

    Follow 6 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2010-05-18 FredKiefer StatusReady For Test Fixed
        Open/ClosedIn Test Closed
    2010-05-13 FredKiefer Item GroupNone Change Request
        StatusNone Ready For Test
        Assigned toNone FredKiefer
        Open/ClosedOpen In Test

    Back to the top

    Powered by Savane 3.13-d3ae.
    Corresponding source code