bugfindutils - Bugs: bug #29593, import-gnulib has #!/bin/sh but is...

 
 

bug #29593: import-gnulib has #!/bin/sh but is not a POSIX sh script

Submitter:  Andreas Metzler <ametzler>
Submitted:  Sun 18 Apr 2010 10:56:04 AM UTC
   
 
Category:  None Severity:  2 - Minor
Item Group:  Compilation Failure Status:  Fixed
Privacy:  Public Assigned to:  jay
Originator Name:  Open/Closed:  Closed
Release:  4.5.8 Fixed Release:  4.5.9
* Mandatory Fields

Add a New Comment Rich Markup
   

Sun 18 Apr 2010 11:55:39 AM UTC, comment #1: 

I just pushed a fix (your suggestion, changing [[ to [).  Thanks!

James Youngman <jay>
Group administrator
Sun 18 Apr 2010 10:56:04 AM UTC, original submission:  

[[ -z "$DO_NOT_WANT_CHANGELOG_DRIVER" ]]

[[ tests ]] is a bash extension, therefore import-gnulib will not work reliably on systems where /bin/sh is dash instead of bash.

There are two ways to fix this:
a) I am /pretty/ sure that all instances of using [[ tests ]] in the script of could simply replaced with [ tests ].

b) Document it. Change the shebang line to /bin/bash and say "bash import-gnulib.sh" in README-hacking.

Andreas Metzler <ametzler>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by jay (Posted a comment)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only logged-in users can vote.

     

    Follow 7 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2011-05-11 jay Open/ClosedOpen Closed
        Fixed ReleaseNone 4.5.9
    2010-04-18 jay Severity3 - Normal 2 - Minor
        Item GroupNone Compilation Failure
        StatusNone Fixed
        Assigned toNone jay
    2010-04-18 ametzler Carbon-CopyRemoved 20807 -

    Back to the top

    Powered by Savane 3.13-4448.
    Corresponding source code