bugDotGNU Portable.NET - Bugs: bug #26225, wrong error message for...

 
 

You are not allowed to post comments on this tracker with your current authentication level.

bug #26225: wrong error message for "abc".ToCharArray(3,1)

Submitter:  Thomas Uxiou <uxiou>
Submitted:  Sat 18 Apr 2009 12:02:46 PM UTC
   
 
Category:  None Severity:  3 - Normal
Item Group:  None Status:  Fixed
Privacy:  Public Assigned to:  ktreichel
Open/Closed:  Closed

Sun 19 Apr 2009 09:54:51 AM UTC, comment #2: 

Fixed with a different solution in cvs.

Klaus Treichel <ktreichel>
Group administrator
Sat 18 Apr 2009 12:41:05 PM UTC, comment #1: 

Hi,

doesn't the simple change from
startindex > length to startindex >= length fix this issue too?


Klaus Treichel <ktreichel>
Group administrator
Sat 18 Apr 2009 12:02:46 PM UTC, original submission:  

"abc".ToCharArray(3,1);

result:

> System.ArgumentOutOfRangeException: String range is out of range
> Parameter name: length


expected:

> System.ArgumentOutOfRangeException: String range is out of range
> Parameter name: startIndex


fix:
# diff a/runtime/System/String.cs b/runtime/System/String.cs
# --- a/runtime/System/String.cs
# +++ b/runtime/System/String.cs
# @@ -1510,7 +1510,7 @@ public sealed class String : IComparable, ICloneable, IEnumerable
#  public char[] ToCharArray(int startIndex, int ilength)
#  {
#  char[] result;
# - if(startIndex < 0 || startIndex > length)
# + if(startIndex < 0 || (0 != length && length <= startIndex) || (0 == length && length != startIndex))
#  {
#  throw new ArgumentOutOfRangeException
#  ("startIndex", _("ArgRange_StringIndex"));x

Thomas Uxiou <uxiou>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by ktreichel (Posted a comment)
  • -email is unavailable- added by uxiou (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

     

    Follow 3 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2009-04-19 ktreichel StatusNone Fixed
        Open/ClosedOpen Closed
    2009-04-18 ktreichel Assigned toNone ktreichel

    Back to the top

    Powered by Savane 3.13-caa5.
    Corresponding source code