bugGnash - The GNU Flash player - Bugs: bug #25499, Bogus liblber dependency

 
 
Show feedback again

bug #25499: Bogus liblber dependency

Submitted by:  Bernhard Rosenkraenzer <bero>
Submitted on:  Thu 05 Feb 2009 03:32:49 PM UTC  
 
Category: coreSeverity: 3 - Normal
Release: trunkStatus: Ready For Test
Privacy: PublicAssigned to: Rob Savoye <rsavoye>
Open/Closed: Open

Add a New Comment (Rich MarkupRich Markup):
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Fri 20 Feb 2009 08:53:36 AM UTC, comment #4:

It's commented out in configure.ac now (commit 10598), though not mentioned in the commit message, so might not have been intended for commit. Either way, it's gone at the moment.

Benjamin Wolsey <bwy>
Project Member
Thu 05 Feb 2009 04:50:29 PM UTC, comment #3:

It was a quick hack to get the release out the door, but yes, this is likely a bogus dependency, and should be removed. As the next release process starts in a week, I'll see about testing and fixing this then while I'm doing other config & build hacking.

Rob Savoye <rsavoye>
Project AdministratorIn charge of this item.
Thu 05 Feb 2009 04:33:07 PM UTC, comment #2:

Please don't punish users of other distributions for Ubuntu's bugs...

A workaround like this should check for the problem instead of being applied unconditionally. Here (on Ark Linux, and quite probably most other non-Ubuntu OSes) nothing gnash uses requires liblber.

Bernhard Rosenkraenzer <bero>
Thu 05 Feb 2009 03:44:58 PM UTC, comment #1:

Actually I added this library check because one of the dependant libraries on Ubuntu Hardy needed this, and didn't have it listed as a dependency for that library, so Gnash wouldn't link. I can try again on Intrepid and see if it's still a problem.

Rob Savoye <rsavoye>
Project AdministratorIn charge of this item.
Thu 05 Feb 2009 03:32:49 PM UTC, original submission:

If built on a system that has liblber installed, gnash links to it without making use of any of its functions, introducing an unnecessary dependency.

It is caused by the

AC_CHECK_LIB(lber, ber_free)

line in configure.ac, which doesn't seem to serve any purpose.

Bernhard Rosenkraenzer <bero>

 

(Note: upload size limit is set to 512 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files
file #17407:  gnash-no-bogus-lber-dep.patch added by bero (409B - text/x-patch - Fix)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by bwy (Posted a comment)
  • -unavailable- added by rsavoye (Posted a comment)
  • -unavailable- added by bero (Submitted the item)
  • -unavailable- added by bero
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter 421 here (basic anti-spam test):

     

     

    Follow 5 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Fri 20 Feb 2009 08:53:36 AM UTCbwyStatusPostponed=>Ready For Test
    Thu 05 Feb 2009 04:50:29 PM UTCrsavoyeStatusNone=>Postponed
      Assigned toNone=>rsavoye
    Thu 05 Feb 2009 03:32:49 PM UTCberoAttached File-=>Added gnash-no-bogus-lber-dep.patch, #17407
      Carbon-Copy-=>Added -unavailable-
    Show feedback again

    Back to the top


    Powered by Savane 3.1-cleanup