bugThe GNU Hurd - Bugs: bug #20906, libstore segfaults when failing to...

 
 

bug #20906: libstore segfaults when failing to open multiple stores

Submitted by:  Carl Fredrik Hammar <hammy>
Submitted on:  Sun 26 Aug 2007 03:59:55 PM UTC  
 
Category: HurdSeverity: 3 - Normal
Priority: 5 - NormalItem Group: None
Status: Ready For TestPrivacy: Public
Assigned to: NoneOriginator Name: 
Open/Closed: OpenReproducibility: Every Time
Size (loc): NonePlanned Release: None
Effort: 0.00
Wiki-like text discussion box: 

Add a New Comment (Rich MarkupRich Markup):
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Sun 26 Aug 2007 03:59:55 PM UTC, original submission:

When layering a store over multiple stores that fail to open, `libchannel' generates a segfault.

To test it just do `settrans -ac foo /hurd/storeio -T file one two', where `one' and `two' doesn't exist. `foo' will crash after a `echo bar > foo'.

This is due to two `of by one' bugs in `store_parsed_open' and `store_open_children' functions of `libstore'.

I have attached a patch fixing them and as a bonus slightly restructures the affected code in `store_open_children' to match `store_parsed_open'.

Carl Fredrik Hammar <hammy>
Project Member

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files
file #13805:  libstore-multiple-stores-cleanup.diff added by hammy (864B - application/octet-stream)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by hammy (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follows 1 latest change.

    Date Changed By Updated Field Previous Value => Replaced By
    Sun 26 Aug 2007 03:59:56 PM UTChammyAttached File-=>Added libstore-multiple-stores-cleanup.diff, #13805

    Back to the top


    Powered by Savane 3.1-cleanup