bugGNU Wget - Bugs: bug #20658, No separate HEAD just for...

 
 

bug #20658: No separate HEAD just for Content-Disposition: make last-minute adjustments based on GET

Submitted by:  Micah Cowan <micahcowan>
Submitted on:  Thu 02 Aug 2007 07:39:40 AM UTC  
 
Category:  Program Logic Severity:  3 - Normal
Priority:  8 Status:  Confirmed
Privacy:  Public Assigned to:  Xin Zou <zouxin>
Originator Name:  Open/Closed:  Open
Release:  None Operating System:  None
Reproducibility:  None Fixed Release:  None
Planned Release:  1.13 Regression:  None
Work Required:  1 - Days Patch Included:  None

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Wed 31 Dec 2008 03:29:10 PM UTC, comment #1:

Hi,
I would like to work this out, so could you please assign it to me, thanks!

For debug and test convenience, I wrote a tiny http server, which could output HTTP streams I need. And I tested bug20360 and bug21041 with that tiny server.

For bug20360, it seems that this bug has already been fixed. When HEAD attempt fails for losing connection, Wget could retry HEAD request and GET won't ignore Content-Disposition.

For bug21041, it hasn't been fixed, Content-Disposition is ignored when HEAD attempt fails for unexpected HTTP status code. And I have found the reason.

For bug20658, I think we can add "--content-disposition-headfirst" boolean option to specify HEAD to be sent first. For "--content-disposition" option, only GET will be sent and should carefully terminate connections in response to a last-minute Content-Disposition that indicates we should not download the file.

I think I can fix and test above three bugs, so it would be convenience if admin could assgin all of them to me:-)

Any suggestions are welcome!

Xin Zou <zouxin>In charge of this item.
Thu 02 Aug 2007 07:39:40 AM UTC, original submission:

This decision based on the belief that Content-Disposition is used relatively rarely, and when it is, it frequently is unavailable in the HEAD response.

It should be configurable (that is, the user should be able to specify that a HEAD be issued first to attempt to get any Content-Disposition headers), but in any case, filenames should absolutely based on the latest information (from GET).

This implies that we will sometimes terminate connections in response to a last-minute Content-Disposition that indicates we should not download the file.

We can move Content-Disposition checks back to the default (which was set to off by default, to avoid all the extra HEAD requests) if we make this change.

Micah Cowan <micahcowan>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by zouxin (Posted a comment)
  • -email is unavailable- added by micahcowan (Submitted the item)
  •  

     

     

    Follow 6 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2009-10-09 micahcowan Planned Release1.14 => 1.13
    2009-01-16 micahcowan Assigned toNone => zouxin
    2008-08-21 micahcowan Planned Release1.12 => 1.14
    2007-10-23 micahcowan Priority9 - Immediate => 8
    2007-08-21 micahcowan Priority6 => 9 - Immediate
    2007-08-02 micahcowan Priority5 - Normal => 6

    Back to the top


    Powered by Savane 3.3