bugPSPP - Bugs: bug #20427, Portable file writer doesn't write...

 
 

bug #20427: Portable file writer doesn't write weight variable

Submitter:  Ben Pfaff <blp>
Submitted:  Tue 10 Jul 2007 04:40:06 AM UTC
   
 
Category:  System/Portable File I/O Severity:  5 - Average
Status:  Fixed Assigned to:  None
Open/Closed:  Closed Release:  None
Effort:  0.00
* Mandatory Fields

Add a New Comment Rich Markup
   

Wed 25 Jul 2007 04:11:01 AM UTC, comment #3: 


>Maybe this reflects some of your other recent patches.


Yes it does.  Sorry about that.  I've switched to using "quilt" for managing my stack of patches (highly recommended BTW).  It makes it so easy to cherry-pick patches out of a pile that sometimes I forget to make sure they're independent.

I checked this in.

Thanks for the review.

Ben Pfaff <blp>
Group administrator
Mon 23 Jul 2007 01:25:33 AM UTC, comment #2: 

After applying this patch, compilation fails with
src/data/por-file-writer.c:319: error: too many arguments to function 'var_get_short_name'
Maybe this reflects some of your other recent patches. 

I don't see any other problems.



John Darrington <jmd>
Group administrator
Sun 22 Jul 2007 05:05:17 AM UTC, comment #1: 

Here's a proposed fix.

(file #13426)

Ben Pfaff <blp>
Group administrator
Tue 10 Jul 2007 04:40:06 AM UTC, original submission:  

The portable file reader reads the weight variable from portable files, but the portable file writer doesn't write the weight variable.  We should fix this.

Ben Pfaff <blp>
Group administrator

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

Attached Files

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by jmd (Posted a comment)
  • -email is unavailable- added by blp (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only logged-in users can vote.

     

    Follow 4 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2007-07-25 blp StatusReady for Test/Review Fixed
        Open/ClosedOpen Closed
    2007-07-22 blp Attached File- Added weight-for-por-file-writer.patch, #13426
        StatusNone Ready for Test/Review

    Back to the top

    Powered by Savane 3.13-758e.
    Corresponding source code