bugfindutils - Bugs: bug #19616, leaf optimisation and loop...

 
 

bug #19616: leaf optimisation and loop detection broken in 4.3.3

Submitter:  James Youngman <jay>
Submitted:  Tue 17 Apr 2007 09:00:32 AM UTC
   
 
Category:  find Severity:  4 - Important
Item Group:  None Status:  Fixed
Privacy:  Public Assigned to:  jay
Originator Name:  Open/Closed:  Closed
Release:  4.3.3 Fixed Release:  4.3.4
* Mandatory Fields

Add a New Comment Rich Markup
   

Tue 17 Apr 2007 09:00:32 AM UTC, original submission:  

In find.c, we have this code around line 1164:

  /* Now we really need to stat the directory, even if we know the
   * type, because we need information like struct stat.st_rdev.
   */
  if (0 == stat_buf.st_mode)
    {
      /* This call was made conditional on Sat Apr 14 16:01:01 2007,
       * and at that time the test suite passed without it.  Omitting
       * this stat call saves a lot of system calls.
       */
      if (get_statinfo(pathname, name, &stat_buf) != 0)
return 0;

      state.have_stat = true;
    }

The conditional nature of that code is incorrect; the function goes on to use stat_buf.st_rdev assuming it is valid. and stat_buf.st_nlinks is used later too.  This probably breaks the leaf optimisation and loop detection.

James Youngman <jay>
Group administrator

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by jay (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only logged-in users can vote.

     

    Follow 3 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2007-04-21 jay Fixed ReleaseNone 4.3.4
    2007-04-21 jay Open/ClosedOpen Closed
    2007-04-17 jay StatusNone Fixed

    Back to the top

    Powered by Savane 3.13-d3ae.
    Corresponding source code