bugfindutils - Bugs: bug #19120, Patch to fix single quotes in man...

 
 

bug #19120: Patch to fix single quotes in man page find(1)

Submitted by:  Reuben Thomas <rrt>
Submitted on:  Thu 22 Feb 2007 01:36:20 AM UTC  
 
Category:  documentation Severity:  3 - Normal
Item Group:  None Status:  Fixed
Privacy:  Public Assigned to:  James Youngman <jay>
Originator Name:  Reuben Thomas Open/Closed:  Closed
Release:  4.2.28 Fixed Release:  4.5.6b

Add a New Comment (Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Fri 10 Jul 2009 10:07:24 AM UTC, comment #5: 

Applied to the 4.5.x tree.

James Youngman <jay>
Project AdministratorIn charge of this item.
Thu 01 May 2008 01:23:41 PM UTC, comment #4: 

If this patch has not already been made in some form, it may help to know that I've made a copyright assignment to findutils, so you can use it.

If it has already been made, feel free to close this item.

Reuben Thomas <rrt>
Sat 07 Jul 2007 09:17:19 AM UTC, comment #3: 

The only problem is size.  Because of the size of the patch, it would require a copyright assignment.  However, the proposed changes are straightforward.  This means it is probably more efficient to point out the specific types of things that need to be changed than to provide a patch.   It's a bit awkward that it should sometimes be more work to apply a patch than re-invent it, but that is the situation in which the GNU projct sometimes unwillingly finds itself.   But see also http://lists.gnu.org/archive/html/findutils-patches/2007-07/msg00001.html

James Youngman <jay>
Project AdministratorIn charge of this item.
Fri 06 Jul 2007 11:46:18 PM UTC, comment #2: 

Is there some problem with this patch? I'd like to see a nicer-looking (and more useful) man page!

Reuben Thomas <rrt>
Sun 24 Jun 2007 04:18:59 PM UTC, comment #1: 

Cool. This has just been pointed out to me in <http://bugs.debian.org/430139> and there is already a patch. ;-)

BTW imho for this specific example the quotes should simply be dropped; i.e. instead of

-find . \-wholename './src/emacs' \-prune \-o \-print
+find . \-wholename \(aq./src/emacs\(aq \-prune \-o \-print

this would be used:
-find . \-wholename './src/emacs' \-prune \-o \-print
+find . \-wholename ./src/emacs \-prune \-o \-print

Otherwise the patch looks fine to me in both C and UTF-8 locale.
cu andreas

Andreas Metzler <ametzler>
Thu 22 Feb 2007 01:36:20 AM UTC, original submission:  

The use of single quotes in this man page is frequently erroneous. My fixes fall into the following categories:

1. Use ` instead of ' at the start of quoted text.

2. Use \(aq instead of ' or \' in commands to get a literal straight quote.

3. Use ` and ' instead of `` and '' (for consistency).

I attach a unified diff against find(1) as shipped with 4.2.28.

Reuben Thomas <rrt>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

Attached Files
file #12024:  find.1.patch added by rrt (10KiB - application/octet-stream)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by jay (Posted a comment)
  • -email is unavailable- added by rrt (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

     

     

    Follow 7 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2010-03-31 jay Open/ClosedOpen => Closed
        Fixed ReleaseNone => 4.5.6b
    2009-07-10 jay StatusNone => Fixed
        Assigned toNone => jay
    2007-06-24 ametzler Carbon-CopyRemoved 20807 => -
    2007-02-22 rrt Attached File- => Added find.1.patch, #12024
        Carbon-Copy- => Added rrt

    Back to the top


    Powered by Savane 3.5