bugGNU gv - Bugs: bug #17636, gv fails to honour X resources

 
 

You are not allowed to post comments on this tracker with your current authentication level.

bug #17636: gv fails to honour X resources

Submitter:  Christoph Berg <myon>
Submitted:  Thu 07 Sep 2006 11:20:53 AM UTC
   
 
Category:  Graphical User interface Severity:  3 - Normal
Item Group:  None Status:  Fixed
Privacy:  Public Assigned to:  jemarch
Open/Closed:  Closed Release:  3.6.2

Thu 28 Jun 2007 01:26:08 PM UTC, comment #2: 

Fixed in CVS.

Jose E. Marchesi <jemarch>
Thu 14 Sep 2006 06:57:40 PM UTC, comment #1: 

I applied the patch submitted by Bernhard Link. Many thanks!

Jose E. Marchesi <jemarch>
Thu 07 Sep 2006 11:20:53 AM UTC, original submission:  

The following was submitted to Debian bug #148533. I can confirm that the provided patch (by Bernhard Link) fixes the issue.

----------------

Gv first reads the current resources, then overwrites them with the
default values.

As easy test, try:
cat > scales <<EOF
GV.scales: Natural size,   1.200,  screen  \n\
Pixel based,    1.200,  pixel   \n\
0.950,          0.950
EOF
xrdb -merge scales
and fire up gv to see it still shows the default menu.

The bug is only a signle True where a False belongs and fixed with the
following patch:

diff -r -u gv-3.6.1/src/main.c gv-patched/src/main.c
--- gv-3.6.1/src/main.c 2004-12-07 00:36:57.000000000 +0100
+++ gv-patched/src/main.c 2006-07-22 14:46:52.450968089 +0200
@@ -607,7 +607,7 @@
      XrmDatabase db;
      INFMESSAGE(getting resources)
      db = resource_buildDatabase(gv_display,gv_class,gv_name,&argc,argv);
-     XrmCombineDatabase(db,&gv_database,True);
+     XrmCombineDatabase(db,&gv_database,False);
    }
 
 /*### initializing widget set and creating application shell #########################*/

At this place gv_display are the current resources, while db consists
out of the default resource values. If overwrite is true, the default
ones overwrite the current ones in gv_databases, discarding anything the
user set via xrdb or in his .Xresources...

Christoph Berg <myon>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attached Files
file #10709:  148533_use_Xresources added by myon (571B - application/octet-stream - patch)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by jemarch (Updated the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

     

    Follow 10 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2007-06-28 jemarch StatusIn Progress Fixed
        Open/ClosedOpen Closed
    2007-06-27 jemarch StatusFixed In Progress
        Open/ClosedClosed Open
    2006-09-14 jemarch StatusIn Progress Fixed
        Open/ClosedOpen Closed
    2006-09-14 jemarch StatusNone In Progress
        Assigned toNone jemarch
    2006-09-14 jemarch ReleaseNone 3.6.2
    2006-09-07 myon Attached File- Added 148533_use_Xresources, #10709

    Back to the top

    Powered by Savane 3.13-758e.
    Corresponding source code