bugGNU Screen - Bugs: bug #14277, Compile fails on solaris

 
 

bug #14277: Compile fails on solaris

Submitter:  None
Submitted:  Wed 24 Aug 2005 04:58:09 PM UTC
   
 
Category:  None Severity:  3 - Normal
Priority:  * 5 - Normal Status:  Duplicate
Privacy:  Public Assigned to:  None
Open/Closed:  Closed Release:  None
Fixed Release:  None Planned Release:  None
Work Required:  None
* Mandatory Fields

Add a New Comment Rich Markup
   

Jump to the original submission

Wed 10 Nov 2010 02:27:46 PM UTC, comment #14: 

Why is this closed? The bug is still in the latest release and I don't see any evidence here that's been committed to the latest sources.

So unless I'm mistaken, the bug is still present.

Dave

Dr. David Kirkby <drkirkby>
Fri 24 Sep 2010 05:46:08 PM UTC, comment #13: 

Hard for me to "use the current development sources" when they don't appear on the downloads page.


Anthony D'Atri <anthony11>
Fri 24 Sep 2010 05:38:33 PM UTC, comment #12: 
Anonymous
Tue 04 May 2010 05:07:53 PM UTC, comment #11: 

The latest released sources were still well before this fix, so it doesn't follow. Sorry, either use the current development sources, or help the maintainers speed up the release (AFAIK, their greatest need before they can release is still updated documentation).

Micah Cowan <micahcowan>
Tue 04 May 2010 04:33:20 PM UTC, comment #10: 

The 15921 fix adds a test for a different platform, not for Sun&SVR4, so this fix still needs to be added.


Anthony D'Atri <anthony11>
Tue 04 May 2010 04:28:36 PM UTC, comment #9: 

This fix is not in the last released sources, screen-4.0.3, so it clearly was not applied.

Anthony D'Atri <anthony11>
Fri 13 Jun 2008 07:49:35 AM UTC, comment #8: 

This appears to be the same fix as for 15921, which is marked "Fixed" and applied. This bug may stand closing, if that's the case.

Micah Cowan <micahcowan>
  Spam posted by anonymous
  Spam posted by anonymous
Fri 14 Mar 2008 08:07:26 AM UTC, comment #5: 

Patch work fine [http://reallydrugs.com/buy-cialis-online.htm  ]

Anonymous
Fri 26 Oct 2007 02:19:11 AM UTC, comment #4: 

Please submit the fix for bug #14277.

I have tried compiling screen in the following configurations and it always fails because of this long outstanding bug:

Environment:
On Solaris 10 x86 (32 bit)
Using the Sun Studio 12 compiler
Or using gcc 3.4.3 (that comes with Solaris 10 /usr/sfw/bin/gcc)
Using Sun make
Using gmake /usr/sfw/bin/gmake

Anonymous
Wed 01 Nov 2006 06:00:00 AM UTC, comment #3: 

Here's a patch to Do The Right Thing and use autoconf to detect the number of setenv() arguments.

Anonymous
Wed 01 Nov 2006 05:18:06 AM UTC, comment #2: 

The correct fix is to use autoconf. A more correct hack fix is to check for (defined(__sun) && defined(__SVR4)), so you don't break ancient SunOS 4.x boxes (if anyone still cares about them).

--- misc.c.DIST 2006-10-31 20:55:42.481760000 -0800
+++ misc.c      2006-10-31 21:03:13.811233000 -0800
@@ -613,7 +613,7 @@
    */
 # endif /* NEEDSETENV */
 #else /* USESETENV */
-# if defined(linux) || defined(_convex_) || (BSD >= 199103)
+# if defined(linux) || defined(_convex_) || (BSD >= 199103) || (defined(__sun) && defined(__SVR4))
   setenv(var, value, 1);
 # else
   setenv(var, value);

Anonymous
Sat 29 Oct 2005 01:40:40 AM UTC, comment #1: 

A slightly cleaner patch would be the following, although I am not sure whether the default for setenv() shouldn't be the version with three arguments.


* misc.c~     Fri Dec  5 05:45:41 2003
--- misc.c      Fri Oct 28 18:37:29 2005
*************
* 613,619 **
     */
  # endif /* NEEDSETENV */
  #else /* USESETENV */
! # if defined(linux) || defined(_convex_) || (BSD >= 199103)
    setenv(var, value, 1);
  # else
    setenv(var, value);
--- 613,619 ----
     */
  # endif /* NEEDSETENV */
  #else /* USESETENV */
! # if defined(linux) || defined(_convex_) || (BSD >= 199103) || defined(_sun_)
    setenv(var, value, 1);
  # else
    setenv(var, value);

Anonymous
Wed 24 Aug 2005 04:58:09 PM UTC, original submission:  

On both screen 3.9.15 and 4.0.2 on Solaris 10:

gcc -c -I. -I.    -O3 -pipe misc.c
misc.c: In function `xsetenv':
misc.c:619: error: too few arguments to function `setenv'
make: * [misc.o] Error 1

Changing misc.c as follows fixed it (obviously a hack)
#else /* USESETENV */
# if defined(linux) || defined(_convex_) || (BSD >= 199103)
  setenv(var, value, 1);
# else
  setenv(var, value);
  setenv(var, value, 1);
# endif /* linux || convex || BSD >= 199103 */
#endif /* USESETENV */

I just commented out what was there and pulled down the line from above.

Anonymous

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

Attached Files
file #11130:  setenv_autoconf.patch added by None (2KiB - application/octet-stream - Use autoconf to determine the number of arguments to setenv())

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by drkirkby (Posted a comment)
  • -email is unavailable- added by anthony11 (Posted a comment)
  • -email is unavailable- added by micahcowan (Posted a comment)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only logged-in users can vote.

     

    Follow 3 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2008-06-13 micahcowan StatusNone Duplicate
        Open/ClosedOpen Closed
    2006-11-01 None Attached File- Added setenv_autoconf.patch, #11130

    Back to the top

    Powered by Savane 3.13-758e.
    Corresponding source code